I have yet to figure out why ANY CS should be ordered past that age, unless they are still in HS.
#1 - I can help you figure it out. It's in the state's best interests to keep as high a CS award as possible going for as long as possible. They receive kickbacks from the Federal government in matching funds for child support collections and enforcement.
#2 - You are correct, many states no longer have provision which forces the payment for education after high school. Some still do. It is unconstitutional and takes legislation to get it changed in each state. The Federal government has not stepped in on that front.
The lawyer is going to do an end-run on you (the OP), I would stop negotiating with her attorney on your own. You're way out of your league and will end up the loser on all counts. Her attorney's job is to get as many things done in her favor as possible.
1. The use of the word Primary in reference to her being the residential parent. - I removed the word primary.It doesn't matter unless one side has the majority of the physical custody. You're changing language that has no bearing on the situation, unless you are retaining more than 50% custody. If 50/50, someone is called the "primary" for the purposes of child support. That title goes to the CS recipient.
2.Iasked that if my ex is going to be the residential custodian thatthechildren both have their own bed to sleep in. -My son has his ownroomand my daughter is forced to sleep with her mother in the same bed.Herlawyer objected to that. He stated the court wouldn't decide onthat. Ithen told him that the court might decide on that since she hasa verycontagious STD and she sleeps in the same bed as my daughter, andmychildren have their own bedrooms at my townhouse.Again, you're out of your league. This issue is so minor and, as others have said, a $50 air mattress takes care of the problem. Beyond that, your ability to police it is non-existent.
3. I haveaskedthat wording be added to reflect that she cannot bring herboyfriend inthe prescence of my children at any time, regardless oftheir maritalstatus because of him being a felon.Good luck policing that, too. Morals clauses are practically unenforceable. Fact is, given that he is a repeat felon, combined with her wishy-washy acts of moving, not moving, moving, not moving, and their living arrangements, you should be looking for full custody until her living arrangements change rather significantly.
4. Child supportends at their19th birthday. - Her papers put us both on the hook foreducationalexpenses and misc expenses until their 24th birthday if theyare inschool. They also extend child support until their 24th birthday.Herlawyer tells me that we do have an obligation as parents to payforcollege should I children decide to go to college and that thewordinghas to be in the papers because the judge will order it anyway.NEVER EVER sign ANYTHING that adds additional burdens that are not required. They're only enforceable if you willfully agree to them. Don't. You make that decision of your own accord later.
CS should end at age 18 or the graduation from high school, whichever is LATER. I would like to know what state you're in to find out if it's one that doesn't impose their will for divorced parents to pay for college educations. And even if they do, you should object readily.
Stop talking to her attorney. It's HER attorney.